Commit a832ab81 authored by Ibrahim Ahmed's avatar Ibrahim Ahmed
Browse files

controller: Does not setup email logging on empty user/password strings

parent 52a1f7d4
Loading
Loading
Loading
Loading
+1 −1
Changes for src/README.md: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@

## Notebooks

* `baseline_condenser`: Using a feedback controller without machine learning to test control of HVAC systems.
* `baseline_condenser`: Using a feedback controller without machine learning to test control of HVAC systems. This is the demo notebook for `baseline_control.SimpleFeedbackController`.

* `Models-v2`: Generating data-driven models from the [`v2` dataset][2], which has been preprocessed. See `docs/datasets/v1/` for more information.

+2 −2
Changes for src/controller.py: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ def get_settings(parsed_args) -> dict:
    settings = {}
    settings.update(vars(parsed_args))
    # try reading them, if error, return previous settings
    cfg = ConfigParser()
    cfg = ConfigParser(allow_no_value=True)
    if parsed_args.settings is None:
        raise ValueError('No settings file provided.')
    cfg.read(parsed_args.settings)
@@ -143,7 +143,7 @@ def make_logger(**settings) -> logging.Logger:
        mailhost is not None and \
        fromaddr is not None and \
        len(toaddrs) > 0 and toaddrs[0]!='' and \
        username is not None and password is not None):
        username not in ('', None) and password not in ('', None)):
        
        logger.info('Setting up email logging.')
        class EmailHandler(BufferingHandler):